MPB3.Radio
Trick Member
![]()
Joined: 05 Dec 2002
Location: P-Town |
0.  Posted: Tue Aug 24, 2004 11:11 am Post subject: Locations page: rating issue |
 |
|
The rating form on the locations page is useless for users of Firefox and I'm assuming other Mozilla-based browsers as well because it:
a) has no submit button
b) uses faulty javascript to submit the form data
It's essentially making the location list IE-only (or Mozilla exclusive, which includes Firefox) as far as consumer feedback goes and it's quite ridiculous since it's rather cumbersome to have to load up IE, then sift through and find the location that I'd like to express my disdain toward all because of a poorly structured form.
Current markup:
| Code: | <script language="javascript">
function Submit() {
rateForm.submit();
}
</script>
<FORM name=rateForm action="locations.php" method=post>
<table border=0 class=standardtext width=400>
<tr>
<td colspan=10 align=left><b>Rate this location:</b></td>
</tr>
<tr>
<td colspan=5 align=left>Don't come here</td>
<td colspan=5 align=right>Hot DDR Location</td>
</tr>
<tr align=center valign=bottom>
<td><input type=radio name=rating value=1 onClick=Submit()></td>
<td><input type=radio name=rating value=2 onClick=Submit()></td>
<td><input type=radio name=rating value=3 onClick=Submit()></td>
<td><input type=radio name=rating value=4 onClick=Submit()></td>
<td><input type=radio name=rating value=5 onClick=Submit()></td>
<td><input type=radio name=rating value=6 onClick=Submit()></td>
<td><input type=radio name=rating value=7 onClick=Submit()></td>
<td><input type=radio name=rating value=8 onClick=Submit()></td>
<td><input type=radio name=rating value=9 onClick=Submit()></td>
<td><input type=radio name=rating value=10 onClick=Submit()></td>
</tr>
<tr align=center valign=top>
<td>1</td>
<td>2</td>
<td>3</td>
<td>4</td>
<td>5</td>
<td>6</td>
<td>7</td>
<td>8</td>
<td>9</td>
<td>10</td>
</tr>
</table>
<input type=hidden name=locationID value=1143>
<input type=hidden name=action value=rateLocation>
</FORM> |
Should be changed to:
| Code: | <form name="rateForm" action="locations.php" method="post">
<table class="standardtext" border="0" width="400">
<tbody><tr>
<td colspan="10" align="left"><b>Rate this location:</b></td>
</tr>
<tr>
<td colspan="5" align="left">Don't come here</td>
<td colspan="5" align="right">Hot DDR Location</td>
</tr>
<tr align="center" valign="bottom">
<td><input name="rating" value="1" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="2" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="3" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="4" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="5" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="6" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="7" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="8" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="9" onclick="form.submit()" type="radio"></td>
<td><input name="rating" value="10" onclick="form.submit()" type="radio"></td>
</tr>
<tr align="center" valign="top">
<td>1</td>
<td>2</td>
<td>3</td>
<td>4</td>
<td>5</td>
<td>6</td>
<td>7</td>
<td>8</td>
<td>9</td>
<td>10</td>
</tr>
</tbody></table>
<input name="locationID" value="1143" type="hidden">
<input name="action" value="rateLocation" type="hidden">
</form> |
And maybe a submit button could be added at the end of the numbers to get around browsers' DOM implementation issues entirely. |
|
Forums FAQ
Search
Memberlist
Usergroups
Register
Profile
Login to check your private messages
Login
